commit 6dce8a82ee034ce7099b0827cb29b50c61e8e572
author Googler <noreply@google.com> Tue May 14 06:56:27 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Tue May 14 06:57:28 2019 -0700
tree d49dc94538e569d507174904dc7c30e718c980d7
parent 4a33f119043673e26fe7573f0758feb5bca95fc1

Avoid garbage from boxing of ints in DirtyBuildingState.isReady.

PiperOrigin-RevId: 248128144

src/main/java/com/google/devtools/build/skyframe/DirtyBuildingState.java

diff --git a/src/main/java/com/google/devtools/build/skyframe/DirtyBuildingState.java b/src/main/java/com/google/devtools/build/skyframe/DirtyBuildingState.java
index 8b95580..42c80c6 100644
--- a/src/main/java/com/google/devtools/build/skyframe/DirtyBuildingState.java
+++ b/src/main/java/com/google/devtools/build/skyframe/DirtyBuildingState.java
@@ -318,12 +318,11 @@
 
   /** Returns whether all known children of this node have signaled that they are done. */
   boolean isReady(int numDirectDeps) {
-    Preconditions.checkState(
-        signaledDeps <= numDirectDeps + externalDeps,
-        "%s %s %s",
-        numDirectDeps,
-        externalDeps,
-        this);
+    // Avoids calling Preconditions.checkState because it showed up in garbage profiles due to
+    // boxing of the int format args.
+    if (signaledDeps > numDirectDeps + externalDeps) {
+      throw new IllegalStateException(String.format("%s %s %s", numDirectDeps, externalDeps, this));
+    }
     return signaledDeps == numDirectDeps + externalDeps;
   }