commit 7222cabcd1d98a1e3f2f3c7eee4f1816c372605a
author emilyguo <emilyguo@google.com> Tue Apr 19 13:32:09 2022 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Apr 19 13:34:32 2022 -0700
tree 888fe51ced7ad5d606b6defc666c50b224d8ace1
parent 54f410c2d72d1f94e4291ac7355ef06919d94936

Change to a lower-noise reporting method.

It can avoid to keep sending Third eye reports, but still get error message to help further investigation.

PiperOrigin-RevId: 442897019

src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java
index 006c639..bb7c9d7 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java
@@ -248,9 +248,8 @@
       for (AspectKey aspectKey : orderedKeys) {
         AspectValue aspectValue = (AspectValue) aspectValues.get(aspectKey);
         if (aspectValue == null) {
-          BugReport.sendBugReport(
-              new IllegalStateException(
-                  "aspectValue " + aspectKey + " was missing, this should never happen"));
+          BugReport.logUnexpected(
+              "aspectValue for: '%s' was missing, this should never happen", aspectKey);
           return null;
         }
         topologicalAspectPathBuilder.add(aspectValue.getAspect());