commit 72744dac084cdc763fc6e1bc1b064223acfe848e
author Eric Fellheimer <felly@google.com> Fri Oct 23 21:38:28 2015 +0000
committer Florian Weikert <fwe@google.com> Tue Oct 27 11:46:06 2015 +0000
tree fe95eecb7a7f625188219490a9d175f785b53717
parent 593b73d0ab9c2020b8d35c0b7b8bde97c5fece06

Avoid unbounded growth in the GlobFunction cache. The cache is now given a maximum size, based off a reasonably larged sized benchmark.

--
MOS_MIGRATED_REVID=106180595

src/main/java/com/google/devtools/build/lib/skyframe/GlobFunction.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/GlobFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/GlobFunction.java
index db63627..0b806cc 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/GlobFunction.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/GlobFunction.java
@@ -42,7 +42,7 @@
 public final class GlobFunction implements SkyFunction {
 
   private final Cache<String, Pattern> regexPatternCache =
-      CacheBuilder.newBuilder().concurrencyLevel(4).build();
+      CacheBuilder.newBuilder().maximumSize(10000).concurrencyLevel(4).build();
 
   private final boolean alwaysUseDirListing;