| commit | 7475b77e0f842c3e142fe0a7d18067ad2b09e6fb | [log] [tgz] |
|---|---|---|
| author | michajlo <michajlo@google.com> | Thu Mar 12 15:10:11 2020 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Mar 12 15:11:19 2020 -0700 |
| tree | 9c01adafc9e5736edf243af8b74fce869f938343 | |
| parent | 5465d158d310458ab2c741731907fff929d4e576 [diff] [blame] |
Lift max attributes per rule-class to 200 sh_posix_toolchain [1] has 180, mostly because it has an attribute per unix command. Lifting to 200 to unbreak them and give them some headroom, and will open a github issue to make sure they know this won't scale infinitely. Still staying below the 254 hard limit to give us headroom to attach misc magic attributes after the check, as well as leaving us with a low-effort way to help users that might find themselves in danger without being able to immediately fix things. Fixes https://github.com/bazelbuild/bazel/issues/10953 [1] https://github.com/tweag/rules_sh/blob/master/sh/posix.bzl RELNOTES: Increase max targets per rule class limit to 200 PiperOrigin-RevId: 300633160
diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java index 594148b..232e18b 100644 --- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java +++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java
@@ -219,7 +219,7 @@ ImmutableList.<String>builder() .add("def impl(ctx): return") .add("r = rule(impl, attrs = {"); - for (int i = 0; i < 150; i++) { + for (int i = 0; i < 200; i++) { linesBuilder.add(" 'attr" + i + "': attr.int(),"); } linesBuilder.add("})");