| commit | 7793f7b09e9e49a1988e6d7b993b852781bd1dea | [log] [tgz] |
|---|---|---|
| author | Googler <jhorvitz@google.com> | Mon Feb 27 10:31:47 2023 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Feb 27 10:33:16 2023 -0800 |
| tree | a323f2ee30c3d5184d1a8d7b065bf6727614f27e | |
| parent | b76ba301c846e87c56fb34b415beb6e90ffed625 [diff] |
Implement full synchronization for `SkyKeyInterner` to ensure that it fulfills the contract of `Interner` - no duplicate instances possible. Prior to this change, there was the possibility of a race condition leading to a thread missing the canonical instance in both the weak interner and the global pool because another thread was simultaneously transferring it. It turns out that weak interning under the synchronization provided by `ConcurrentHashMap#computeIfAbsent` is reasonably efficient. Benchmarks show that `-DBAZEL_USE_POOLED_SKY_KEY_INTERNER=1` with this change performs on-par with the current state (special `SkyKey` interning disabled). My brief explanation for this is: * In the common case where a node is already present in the graph, interning is performing lock-free lookups on `ConcurrentHashMap`, which is much faster than the archaic `MapMakerInternalMap` that backs Guava's interner. * The optimization in this change to only call `removeWeak` when a node is newly created helps avoid a lot of unnecessary interaction with the Guava interner. PiperOrigin-RevId: 512666596 Change-Id: I67c28a7bfab6d49e65b2aba59ec9d19074ea493d
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
