| commit | 78c4db45466500ff745b892b46f10378c6011a84 | [log] [tgz] |
|---|---|---|
| author | Googler <gregce@google.com> | Thu Apr 18 09:20:44 2024 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Apr 18 09:22:39 2024 -0700 |
| tree | 98e0b79ecc5865b3db1b1a3eb74bdc10609efe26 | |
| parent | 6062db14b775360ecd97e43b7bdb9049ac6674a1 [diff] |
`apple_crosstool_transition`: don't trigger if `--platforms` already matches the desired Apple platform. Copies similar logic on `--cpu` + `--crosstool_top`. Part of an effort to remove reliance on pre-platform flags like `--cpu` and `--crosstool_top`. ### Context: Fixes a bug when `--incompatible_disable_objc_library_transition` is unset: The Apple C++ toolchain reads `--platforms`. If a `cc_binary` depends on an `objc_library`, the `objc_library` triggers `apple_crosstool_transition`. if `--platforms` is already set to an Apple C++ toolchain, this should be a no-op. If we don't make it a no-op, it forks into a new configuration. This can make common `cc_libraries` ODR (like if the `cc_binary` depends directly on a `cc_library` and the `objc_library` also depends on that `cc_library`). If `--incompatible_disable_objc_library_transition` is set, the no-op [already happens](https://github.com/bazelbuild/bazel/blob/32def7092155a0fcdb138cfd80c51608a7326bcb/src/main/starlark/builtins_bzl/common/objc/objc_library.bzl#L143) without this change. But that's only for `objc_library`. Other rules might also use this transition. PiperOrigin-RevId: 626057015 Change-Id: I9b65e0a3d91a99f63a0d33a9c37304edcff8bc14
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
