Return SpawnResults using a List instead of a Set.
Currently we don't care about the list order of SpawnResults. However, we may care about the list order later. Also, if the equals() method for SpawnResults is ever changed then it may be problematic to return SpawnResults in a Set.
Aside: ActionResults use SpawnResults to calculate cumulative execution times for Actions, and may provide other metrics in future.
RELNOTES: None.
PiperOrigin-RevId: 176579460
diff --git a/src/test/java/com/google/devtools/build/lib/standalone/StandaloneSpawnStrategyTest.java b/src/test/java/com/google/devtools/build/lib/standalone/StandaloneSpawnStrategyTest.java
index 10b0f35..342680b 100644
--- a/src/test/java/com/google/devtools/build/lib/standalone/StandaloneSpawnStrategyTest.java
+++ b/src/test/java/com/google/devtools/build/lib/standalone/StandaloneSpawnStrategyTest.java
@@ -60,7 +60,7 @@
import java.io.IOException;
import java.util.Arrays;
import java.util.Collection;
-import java.util.Set;
+import java.util.List;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
@@ -171,7 +171,7 @@
assertThat(err()).isEmpty();
}
- private Set<SpawnResult> run(Spawn spawn) throws Exception {
+ private List<SpawnResult> run(Spawn spawn) throws Exception {
return executor.getSpawnActionContext(spawn.getMnemonic()).exec(spawn, createContext());
}
