| commit | 79764b22165fbca00dee2c904d1f40bb3714e33b | [log] [tgz] |
|---|---|---|
| author | Googler <brandjon@google.com> | Fri Nov 15 12:37:58 2024 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Nov 15 12:39:16 2024 -0800 |
| tree | e09511b24ae2f2395add9c4d64d5719f86ae7439 | |
| parent | 54a9c0b7e8b23eb7338bf38022745e9095b80641 [diff] |
Don't select()-promote None values
Previously it was thought that the default value of attr.label(), None, should be promoted to select({"//conditions:default": None}) inside a symbolic macro, for symmetry with all other attribute values. But during the design of attribute inheritance, it was discovered that it's simpler to leave Nones unpromoted, and this is likely the lesser of two evils. See GH issue for more context: https://github.com/bazelbuild/bazel/issues/24319#issuecomment-2479678227
Drive-by change in test case labelVisitation(): Add extra branch to select() to ensure it isn't eliminated by automatic select unwrapping, which would defeat the test's coverage.
Work toward #24319. Blocks Bazel 8.0.
PiperOrigin-RevId: 696969888
Change-Id: I53b011d80aa0255e2e5882044423a746a4ca46c1
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
