commit 7d265e07e7a1e37f04d53342710e4f21d9ee8083
author Damien Martin-Guillerez <dmarting@google.com> Fri Jul 01 13:33:48 2016 +0000
committer Damien Martin-Guillerez <dmarting@google.com> Fri Jul 01 13:36:48 2016 +0000
tree d84b71d801ab8065f9f4f5b94972643c4c26b580
parent fdb5a8c06985d78c55981a981a72bd4f0766ddb8

Add all the sources to //:srcs filegroup and add a check to detect
missing file to it.

We need to activate this check on presubmits

--
Change-Id: Ia95e92d3816ce92bb69bc0e2cf56e9c60b68d970
Reviewed-on: https://bazel-review.googlesource.com/#/c/3949/
MOS_MIGRATED_REVID=126404792

examples/BUILD

diff --git a/examples/BUILD b/examples/BUILD
index 781c81a..b2ec284 100644
--- a/examples/BUILD
+++ b/examples/BUILD
@@ -2,11 +2,13 @@
 
 filegroup(
     name = "srcs",
-    srcs = [
+    srcs = glob(["**"]) + [
+        "//examples/android/java/bazel:srcs",
         "//examples/cpp:srcs",
         "//examples/gen:srcs",
         "//examples/java-native:srcs",
         "//examples/java-skylark:srcs",
+        "//examples/j2objc:srcs",
         "//examples/objc:srcs",
         "//examples/py:srcs",
         "//examples/py_native:srcs",

examples/android/java/bazel/BUILD

diff --git a/examples/android/java/bazel/BUILD b/examples/android/java/bazel/BUILD
index 293fb5d..ad550b5 100644
--- a/examples/android/java/bazel/BUILD
+++ b/examples/android/java/bazel/BUILD
@@ -1,3 +1,9 @@
+filegroup(
+    name = "srcs",
+    srcs = glob(["**"]),
+    visibility = ["//examples:__pkg__"],
+)
+
 android_library(
     name = "lib",
     srcs = ["Lib.java"],

examples/cpp/BUILD

diff --git a/examples/cpp/BUILD b/examples/cpp/BUILD
index 7c0543e..3048a0d 100644
--- a/examples/cpp/BUILD
+++ b/examples/cpp/BUILD
@@ -26,8 +26,5 @@
 
 filegroup(
     name = "srcs",
-    srcs = ["BUILD"] + glob([
-        "**/*.cc",
-        "**/*.h",
-    ]),
+    srcs = glob(["**"]),
 )

examples/j2objc/BUILD

diff --git a/examples/j2objc/BUILD b/examples/j2objc/BUILD
index 41c7bb7..0a3d389 100644
--- a/examples/j2objc/BUILD
+++ b/examples/j2objc/BUILD
@@ -42,10 +42,6 @@
 
 filegroup(
     name = "srcs",
-    srcs = glob([
-        "J2ObjcExample/*",
-        "src/**",
-        "BUILD",
-    ]),
+    srcs = glob(["**"]),
     visibility = ["//examples:__pkg__"],
 )

examples/java-native/BUILD

diff --git a/examples/java-native/BUILD b/examples/java-native/BUILD
index b698a88..4f4ecd1 100644
--- a/examples/java-native/BUILD
+++ b/examples/java-native/BUILD
@@ -2,7 +2,7 @@
 
 filegroup(
     name = "srcs",
-    srcs = [
+    srcs = glob(["**"]) + [
         "//examples/java-native/src/main/java/com/example/myproject:srcs",
         "//examples/java-native/src/main/resources:srcs",
         "//examples/java-native/src/test/java/com/example/myproject:srcs",

examples/java-skylark/BUILD

diff --git a/examples/java-skylark/BUILD b/examples/java-skylark/BUILD
index 9a76f2b..74541ae 100644
--- a/examples/java-skylark/BUILD
+++ b/examples/java-skylark/BUILD
@@ -2,7 +2,7 @@
 
 filegroup(
     name = "srcs",
-    srcs = [
+    srcs = glob(["**"]) + [
         "//examples/java-skylark/src/main/java/com/example/myproject:srcs",
         "//examples/java-skylark/src/main/resources:srcs",
         "//examples/java-skylark/src/test/java/com/example/myproject:srcs",

examples/shell/BUILD

diff --git a/examples/shell/BUILD b/examples/shell/BUILD
index 9aba320..4b51df1 100644
--- a/examples/shell/BUILD
+++ b/examples/shell/BUILD
@@ -24,5 +24,5 @@
 
 filegroup(
     name = "srcs",
-    srcs = ["BUILD"] + glob(["**/*.sh"]) + glob(["**/*.txt"]),
+    srcs = glob(["**"]),
 )