| commit | 7d879595cf9e1a9ea568b0d507ed030bd7f13eb8 | [log] [tgz] |
|---|---|---|
| author | adonovan <adonovan@google.com> | Wed Dec 18 08:05:14 2019 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Dec 18 08:06:17 2019 -0800 |
| tree | e49329cecfd04586a46a994137ee1d6bdd675c17 | |
| parent | 910079bef2a64b06cc17dd912f97a87298de0b9b [diff] |
bazel skylarkinterface processor: check parameter types match annotations The SkylarkCallable annotation processor historically did not check statically that the annotation types in Param.type and Param.allowed_types are assignable to the parameter variable, resulting in bugs such as https://github.com/bazelbuild/bazel/issues/9463 in which the annotation type check succeeds but then the reflective call explodes. This change causes the annotation processor to ensure that the annotation types are assignable to the variable, and fixes up a number of places that violated the rule. (A prettier fix for the SkylarkAttr violations is in unknown commit.) Also: - fold verifyParamGenericTypes into the mass of parameter checks. - allow reporting of errors against any element. - report multiple errors in one run; don't throw exceptions. - report parameter errors against parameters, not the method. - rename parameter to paramAnnot and methodParam to param. - use proper type equality not string equality checks. PiperOrigin-RevId: 286193084
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
