| commit | 7d8d55ac84b771a3efa3aec1c126cf0f61b374a4 | [log] [tgz] |
|---|---|---|
| author | Stiopa Koltsov <stepan.koltsov@gmail.com> | Tue Jan 04 11:42:58 2022 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Jan 04 11:44:10 2022 -0800 |
| tree | 0be215eec329efbe2db0cd6fb60e0d399a63b79d | |
| parent | 238b6ac5169b4f2effd74c18e5aa6dadf4dc0a4d [diff] |
Starlark: faster dict.keys
Calling `Dict.entries()` to implement `keys` is suboptimal because it:
* wraps with unmodifiable map
* creates `Map.Entry` object for each iteration
This commit also calls `contents.entrySet()` for `items`, but that's
done mostly for consistency.
Test:
```
def test():
for i in range(10):
d = {1: 2, 3: 4}
for j in range(3000000):
d.keys()
test()
```
Result:
```
A: N=17, r=4.813+-0.260
B: N=17, r=4.373+-0.212
B/A: 0.909
```
Closes #12480.
PiperOrigin-RevId: 419645062
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
