commit 7f24022ce943c58dc4049b5206e39ab37d10f8ee
author Nathan Harmata <nharmata@google.com> Sun Sep 13 02:03:26 2015 +0000
committer Kristina Chodorow <kchodorow@google.com> Mon Sep 14 15:39:28 2015 +0000
tree e729da65461699cc28fb0ea3b719af6d3c12b08d
parent 15da9be94f3ff6771e38442f0bc8f1316faa4e47

Use the file size from FileValue instead of wastefully stat'ing the file again in order to get the file size in ParserInputSource#create (used multiple times for each BUILD file and Skylark .bzl file).

--
MOS_MIGRATED_REVID=102930870

src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java
index 12eea02..cf0bf4e 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java
@@ -446,7 +446,7 @@
         // Skylark dependencies.
         reporter.handle(Event.progress("Loading package: " + packageName));
       }
-      inputSource = ParserInputSource.create(buildFilePath);
+      inputSource = ParserInputSource.create(buildFilePath, buildFileValue.getSize());
     } catch (IOException e) {
       env.getListener().handle(Event.error(Location.fromFile(buildFilePath), e.getMessage()));
       // Note that we did this work, so we should conservatively report this error as transient.