Implement `SkyframeLookupResult` and `SkyframeIterableResult` without temporary data structures.

They now retrieve values by going to the backing maps in `SkyFunctionEnvironment`. This avoids constructing a garbage map/list for every Skyframe request. It also avoids constructing the `ValueOrUntypedException` wrapper.

A behavioral change is that now values requested in a previous request can be retrieved from a later result even if they were not requested. This seems benign as the deps are already properly accounted for, and if it currently happens anywhere, it would have triggered the bug report.

There is really no reason to use `getOrderedValuesAndExceptions` now. It just delegates to `getValuesAndExceptions` and creates an additional `SkyframeIterableResult`. I left a TODO to delete it.

`SimpleSkyframeLookupResult`, `SimpleSkyframeIterableResult`, and `ValueOrUntypedException` are moved to the test source tree.

PiperOrigin-RevId: 477287013
Change-Id: I90262d16a31f056dcdcaecd9ca4cb1c6afe6c5b8
6 files changed
tree: e8bf49b5af7838ad90c535d1b233624a854f1bf8
  1. .bazelci/
  2. .github/
  3. examples/
  4. scripts/
  5. site/
  6. src/
  7. third_party/
  8. tools/
  9. .bazelrc
  10. .gitattributes
  11. .gitignore
  12. AUTHORS
  13. BUILD
  14. CHANGELOG.md
  15. CODE_OF_CONDUCT.md
  16. CODEBASE.md
  17. CODEOWNERS
  18. combine_distfiles.py
  19. combine_distfiles_to_tar.sh
  20. compile.sh
  21. CONTRIBUTING.md
  22. CONTRIBUTORS
  23. distdir.bzl
  24. distdir_deps.bzl
  25. LICENSE
  26. MODULE.bazel
  27. README.md
  28. SECURITY.md
  29. WORKSPACE
  30. WORKSPACE.bzlmod
README.md

Bazel

{Fast, Correct} - Choose two

Build and test software of any size, quickly and reliably.

  • Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.

  • One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.

  • Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.

  • Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.

Getting Started

Documentation

Reporting a Vulnerability

To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.

Contributing to Bazel

See CONTRIBUTING.md

Build status