starlark: make Starlark.addMethods reject fields

Previously, addMethods would also create a BuiltinCallable for
each Java method annotated with structField=True, even though
it was never intended to support that. Field methods are
problematic because merely accessing them invokes the Java
function, yet we don't have the correct Semantics available,
nor can we possibly deal with an InterruptedException.
Now, it rejects them.

- Add test of addMethods, and assertion in BuiltinCallable.
- Update tests of "proxy object" to use dir+getattr instead
  of addMethods.
- Improve doc comments.
- un-deprecate getAnnotation method. It seems reasonable given
  that the annotations are public API, and it is related to the
  core purpose of the class.
- change string method to report "<built-in method append of list value>"
  when appropriate, matching Python[23] and go.starlark.net.
  This is a minor incompatible behavior change, but I could not find
  any places in Google's code base that would break, which is a good sign.
- Replace calls to private BuiltinCallable() in tests with getattr.

PiperOrigin-RevId: 332477998
10 files changed
tree: 0f95be7e01b3fe255c6530a90d63f2a4b795ed6c
  1. .bazelci/
  2. examples/
  3. scripts/
  4. site/
  5. src/
  6. third_party/
  7. tools/
  8. .bazelrc
  9. .gitattributes
  10. .gitignore
  11. AUTHORS
  12. BUILD
  13. CHANGELOG.md
  14. CODEBASE.md
  15. CODEOWNERS
  16. combine_distfiles.py
  17. combine_distfiles_to_tar.sh
  18. compile.sh
  19. CONTRIBUTING.md
  20. CONTRIBUTORS
  21. distdir.bzl
  22. ISSUE_TEMPLATE.md
  23. LICENSE
  24. README.md
  25. WORKSPACE
README.md

Bazel

{Fast, Correct} - Choose two

Build and test software of any size, quickly and reliably.

  • Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.

  • One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.

  • Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.

  • Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.

Getting Started

Documentation

Contributing to Bazel

See CONTRIBUTING.md

Build status