| commit | 807f2a1929e23b60b237c63fadb25af81de2e3c3 | [log] [tgz] |
|---|---|---|
| author | Philipp Schrader <philipp.schrader@gmail.com> | Tue Mar 16 11:45:45 2021 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Mar 16 11:46:40 2021 -0700 |
| tree | 8bdff90b41378be5753674cf974f8269b884069f | |
| parent | 586de95cbd4ac0375eba539d295edcb5bb2819c6 [diff] |
Fix Incompatible Target Skipping for test args
Before the fix, the test in this patch would error out with the
following message:
ERROR: ...: in args attribute of sh_test rule //target_skipping:foo_test: label '//target_skipping:some_foo3_target' in $(location) expression expands to no files
The problem was that the `RunfilesSupport` class for the
`RunfilesProvider` instance was computing the arguments as the
incompatible target was being constructed. That meant that the
arguments get evaluated and it would try to resolve things like
`$(location :incompatible_dep)`. That can't really succeed so bazel
would throw an error.
This patch makes it so arguments are ignored when constructing an
incompatible target.
Closes #13219.
PiperOrigin-RevId: 363233765
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
