| commit | 821d85032f53d70335919ef69de5d679b7f28541 | [log] [tgz] |
|---|---|---|
| author | adonovan <adonovan@google.com> | Tue Nov 10 13:23:32 2020 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Nov 10 13:24:32 2020 -0800 |
| tree | 39d5af818a1cb5d879de953064fbb159ec9b1598 | |
| parent | 285053354655a680521bc1a82c4441ffce506a93 [diff] |
bazel runtime: fix cast error in BuildEventStreamer commit 841ac61469ed61325acbcb134b6d372316f46540 changed expandSet to use NestedSetBuilder instead of manipulating set internals directly. However, the builder "inlines" new NestedSetBuilder().addTransitive(x).build() to just x, which violates the postcondition of expandSet that all direct elements are instances of class ExpandedArtifact. (This can only happen if a non-leaf set has a single non-leaf successor x, and one or more leaf successors all of which cause visitArtifacts to be be a no-op, such as a middleman artifact.) The fix is to handle the "inline" case specially, and apply expandSet recursively to the resulting set. Thanks to Janak for adding the test that eluded me. BUG=159359614 PiperOrigin-RevId: 341684675
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md
