Remove Runfiles.Builder.addLegacyExtraMiddleman(). Its last call site was in android_device. My best guess from the history of this line of code (see https://cr.bazel.build/31030 and issue #4090) is that its intended effect was that the runfiles tree of the unified Android launcher (?) should be built when the android_device rule is. However, I have evidence that it's not necessary: if a particular runfiles tree is needed for the execution of an action, it should be part of the Spawn representing that action. The fact that the tests pass seem to imply that this is already the case. A weak additional piece of evidence is that the runfiles middleman is already in extraFilesToRun, which in turn becomes parts of the FilesToRun of android_device. RELNOTES: None. PiperOrigin-RevId: 582572750 Change-Id: Id70e01501b3de7665941703efb7c457d7a03d434
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md