commit 83545c37f506434d527b577589bebadf96146b22
author ccalvarin <ccalvarin@google.com> Wed Jun 20 11:02:36 2018 -0700
committer Copybara-Service <copybara-piper@google.com> Wed Jun 20 11:04:09 2018 -0700
tree d7ca75c51752750d1d7e3d45e95f4eba4231dda1
parent 07460fc320b774cbd6def67dad983932f7cad1a7

Add better tests for the -h and -help accepted values.

It looks like this test was intended to add coverage for these option-like values that we accept as commands, but it did not actually test this.

RELNOTES: None.
PiperOrigin-RevId: 201380534

src/test/cpp/option_processor_test.cc

diff --git a/src/test/cpp/option_processor_test.cc b/src/test/cpp/option_processor_test.cc
index d963fbb..6048b80 100644
--- a/src/test/cpp/option_processor_test.cc
+++ b/src/test/cpp/option_processor_test.cc
@@ -78,6 +78,19 @@
     EXPECT_EQ(expected.command_args, result->command_args);
   }
 
+  void HelpArgIsInterpretedAsACommand(const std::string& arg) {
+    const std::vector<std::string> args = {"bazel", arg};
+    std::string error;
+    ASSERT_EQ(blaze_exit_code::SUCCESS,
+              option_processor_->ParseOptions(args, workspace_, cwd_, &error))
+        << error;
+    ASSERT_EQ("", error);
+
+    EXPECT_EQ(arg, option_processor_->GetCommand());
+    EXPECT_EQ(std::vector<std::string>({}),
+              option_processor_->GetExplicitCommandArguments());
+  }
+
   const std::string workspace_;
   const std::string cwd_;
   const std::unique_ptr<WorkspaceLayout> workspace_layout_;
@@ -108,7 +121,7 @@
             option_processor_->GetExplicitCommandArguments());
 }
 
-TEST_F(OptionProcessorTest, CanParseHelpArgs) {
+TEST_F(OptionProcessorTest, CanParseHelpCommandSurroundedByOtherArgs) {
   const std::vector<std::string> args =
       {"bazel",
        "--host_jvm_args=MyParam", "--nobatch",
@@ -132,6 +145,18 @@
             option_processor_->GetExplicitCommandArguments());
 }
 
+TEST_F(OptionProcessorTest, CanParseHelpCommand) {
+  HelpArgIsInterpretedAsACommand("help");
+}
+
+TEST_F(OptionProcessorTest, CanParseHelpShortFlag) {
+  HelpArgIsInterpretedAsACommand("-h");
+}
+
+TEST_F(OptionProcessorTest, CanParseHelpFlag) {
+  HelpArgIsInterpretedAsACommand("-help");
+}
+
 TEST_F(OptionProcessorTest, CanParseEmptyArgs) {
   const std::vector<std::string> args = {"bazel"};
   std::string error;