commit 83c5bb00b59137effd976e4f510f74613d85ee1c
author mschaller <mschaller@google.com> Wed Feb 19 15:29:17 2020 -0800
committer Copybara-Service <copybara-worker@google.com> Wed Feb 19 15:30:13 2020 -0800
tree efffed53c0aab30a2bf35bce2dfc453c256f39ed
parent 3187f3da68ac311128ec1095f1630ba6b3ea5275

Refactor (Simple)SpawnResult to reduce invalid representations

This moves status-related helper method implementations from the concrete
implementation to default methods on the interface, making their
semantics clearer, and encouraging other implementations of the interface
to behave the same.

This also strengthens status/exitCode assertions in SpawnResult.Builder's
build method. This makes misuse less likely.

RELNOTES: None.
PiperOrigin-RevId: 296071684

src/test/java/com/google/devtools/build/lib/actions/SpawnResultTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/actions/SpawnResultTest.java b/src/test/java/com/google/devtools/build/lib/actions/SpawnResultTest.java
index 59de66f..2e9b0ff 100644
--- a/src/test/java/com/google/devtools/build/lib/actions/SpawnResultTest.java
+++ b/src/test/java/com/google/devtools/build/lib/actions/SpawnResultTest.java
@@ -38,7 +38,7 @@
         new SpawnResult.Builder()
             .setStatus(SpawnResult.Status.TIMEOUT)
             .setWallTime(Duration.ofSeconds(5))
-            .setExitCode(1)
+            .setExitCode(SpawnResult.POSIX_TIMEOUT_EXIT_CODE)
             .setRunnerName("test")
             .build();
     assertThat(r.getDetailMessage("", "", false, false, false))
@@ -50,7 +50,7 @@
     SpawnResult r =
         new SpawnResult.Builder()
             .setStatus(SpawnResult.Status.TIMEOUT)
-            .setExitCode(1)
+            .setExitCode(SpawnResult.POSIX_TIMEOUT_EXIT_CODE)
             .setRunnerName("test")
             .build();
     assertThat(r.getDetailMessage("", "", false, false, false))