| commit | 84d1a7210d7f78ede41f2359678aa6a7edf72b51 | [log] [tgz] |
|---|---|---|
| author | Fabian Meumertzheim <fabian@meumertzhe.im> | Wed Jan 03 04:57:52 2024 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Jan 03 04:59:15 2024 -0800 |
| tree | e3865d85ea3495fd56b17f7af5a5f75910b3936a | |
| parent | 824e1fe3b17e78089aabcef7ffe763d446318334 [diff] |
Make runfiles incrementally correct with `--nobuild_runfile_links` Fixes three separate but related issues with `--nobuild_runfile_links`: * On all OSes, flipping `--enable_runfiles` from on to off did not result in runfiles being cleared due to a missing call to `SymlinkTreeHelper#clearRunfilesDirectory` that was only added to `SymlinkTreeStrategy` in f84329e007e2421c92805b50da135af411ee754c. * On Windows only, flipping `--enable_runfiles` from off to on did not result in runfiles being created since the logic in `RunfilesTreeUpdater` would see a copy of the manifest instead of a symlink. This is fixed by additionally checking whether the runfiles directory contains the first runfile on Windows. If runfiles were disabled before, it won't, otherwise it will. * On all OSes, `--noenable_runfiles` was ignored by `bazel run`, with runfiles always being created. This is fixed by using `RunfilesTreeUpdater` instead of custom and incorrect logic. With the fixed behavior, the runfiles tree for tests is now cleared right before the test spawn is executed, which makes the test action unable to create its working directory, the subdirectory of the runfiles directory corresponding to the workspace name. To fix this and also get rid of the inconsistency of having another action write into the runfiles tree, this logic is moved into the `SymlinkTreeHelper` and thus applied to all runfiles trees. Work towards #20676 Fixes #19333 Closes #20695. PiperOrigin-RevId: 595369235 Change-Id: I32efc0e6a1d29291470ce5eafcc69bbd9ab276b9
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
