Make ActionStats a private-static inner class of MetricsCollector
The google style guide dicates one top-level class per java file:
https://google.github.io/styleguide/javaguide.html#s3.4.1-one-top-level-class.
Since this class isn't used anywhere else, just move it into MetricsCollector
and make it private.
PiperOrigin-RevId: 450055009
diff --git a/src/main/java/com/google/devtools/build/lib/metrics/MetricsCollector.java b/src/main/java/com/google/devtools/build/lib/metrics/MetricsCollector.java
index e206943..3f08112 100644
--- a/src/main/java/com/google/devtools/build/lib/metrics/MetricsCollector.java
+++ b/src/main/java/com/google/devtools/build/lib/metrics/MetricsCollector.java
@@ -63,20 +63,6 @@
import java.util.concurrent.atomic.LongAccumulator;
import java.util.stream.Stream;
-class ActionStats {
- LongAccumulator firstStarted;
- LongAccumulator lastEnded;
- AtomicLong numActions;
- String mnemonic;
-
- ActionStats(String mnemonic) {
- this.mnemonic = mnemonic;
- firstStarted = new LongAccumulator(Math::min, Long.MAX_VALUE);
- lastEnded = new LongAccumulator(Math::max, 0);
- numActions = new AtomicLong();
- }
-}
-
class MetricsCollector {
private final CommandEnvironment env;
private final boolean recordMetricsForAllMnemonics;
@@ -313,4 +299,18 @@
}
return timingMetrics.build();
}
+
+ private static class ActionStats {
+ final LongAccumulator firstStarted;
+ final LongAccumulator lastEnded;
+ final AtomicLong numActions;
+ final String mnemonic;
+
+ ActionStats(String mnemonic) {
+ this.mnemonic = mnemonic;
+ firstStarted = new LongAccumulator(Math::min, Long.MAX_VALUE);
+ lastEnded = new LongAccumulator(Math::max, 0);
+ numActions = new AtomicLong();
+ }
+ }
}
