commit 8529746358ff5d88dc7ddf584a85ba0aa1a269a8
author gregce <gregce@google.com> Fri Aug 18 21:20:29 2017 +0200
committer Damien Martin-Guillerez <dmarting@google.com> Mon Aug 21 14:15:59 2017 +0200
tree 5aa2c9f9e6f22b37d4d1c320d21fa4436545051b
parent 8158a286a8e72ec3f5259d155f6856fea9d07fea

Replace TransitionApplier interface with a dedicated class.

This accomplishes a few goals:

 1. Removes the outdated BuildConfiguration.StaticConfigurationApplier code.
 2. Removes the TransitionApplier abstraction completely. This was an awkward
    bridge meant to support both static and dynamic implementations.
 3. Moves transition logic to its own dedicated class: ConfigurationResolver.
    This no longer belongs in BuildConfiguration, which we ultimately want to
    become a simple <key, value> map.

Part of the static config cleanup effort.

PiperOrigin-RevId: 165736955

src/main/java/com/google/devtools/build/lib/analysis/BuildView.java

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/BuildView.java b/src/main/java/com/google/devtools/build/lib/analysis/BuildView.java
index 2644780..cb4f086 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/BuildView.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/BuildView.java
@@ -1061,6 +1061,10 @@
     }
 
     class SilentDependencyResolver extends DependencyResolver {
+      private SilentDependencyResolver() {
+        super(ruleClassProvider.getDynamicTransitionMapper());
+      }
+
       @Override
       protected void invalidVisibilityReferenceHook(TargetAndConfiguration node, Label label) {
         throw new RuntimeException("bad visibility on " + label + " during testing unexpected");