commit 858057c2e1d8f7de77c5ca1ea7750015efbc52b9
author cparsons <cparsons@google.com> Tue Sep 17 13:16:24 2019 -0700
committer Copybara-Service <copybara-worker@google.com> Tue Sep 17 13:17:52 2019 -0700
tree c0b26d8b76307dd19d8b100f894030592c0f1c68
parent 6e24b7d53ac1f87e51f36720aeb64c4df2fb9379

Silently return None on unknown invocations of functions of the native module

Also add internal type PintoModuleProvider to the list of non-bootstrap globals.

RELNOTES: None.
PiperOrigin-RevId: 269639202

src/main/java/com/google/devtools/build/skydoc/fakebuildapi/FakeSkylarkNativeModuleApi.java

diff --git a/src/main/java/com/google/devtools/build/skydoc/fakebuildapi/FakeSkylarkNativeModuleApi.java b/src/main/java/com/google/devtools/build/skydoc/fakebuildapi/FakeSkylarkNativeModuleApi.java
index 5939c69..b9a4a26 100644
--- a/src/main/java/com/google/devtools/build/skydoc/fakebuildapi/FakeSkylarkNativeModuleApi.java
+++ b/src/main/java/com/google/devtools/build/skydoc/fakebuildapi/FakeSkylarkNativeModuleApi.java
@@ -14,8 +14,11 @@
 
 package com.google.devtools.build.skydoc.fakebuildapi;
 
+import com.google.common.collect.ImmutableCollection;
+import com.google.common.collect.ImmutableList;
 import com.google.devtools.build.lib.events.Location;
 import com.google.devtools.build.lib.skylarkbuildapi.SkylarkNativeModuleApi;
+import com.google.devtools.build.lib.syntax.ClassObject;
 import com.google.devtools.build.lib.syntax.Environment;
 import com.google.devtools.build.lib.syntax.EvalException;
 import com.google.devtools.build.lib.syntax.FuncallExpression;
@@ -23,11 +26,10 @@
 import com.google.devtools.build.lib.syntax.SkylarkDict;
 import com.google.devtools.build.lib.syntax.SkylarkList;
 import com.google.devtools.build.lib.syntax.SkylarkList.MutableList;
+import javax.annotation.Nullable;
 
-/**
- * Fake implementation of {@link SkylarkNativeModuleApi}.
- */
-public class FakeSkylarkNativeModuleApi implements SkylarkNativeModuleApi {
+/** Fake implementation of {@link SkylarkNativeModuleApi}. */
+public class FakeSkylarkNativeModuleApi implements SkylarkNativeModuleApi, ClassObject {
 
   @Override
   public SkylarkList<?> glob(
@@ -74,4 +76,25 @@
   public String repositoryName(Location location, Environment env) throws EvalException {
     return "";
   }
+
+  @Nullable
+  @Override
+  public Object getValue(String name) throws EvalException {
+    // Bazel's notion of the global "native" isn't fully exposed via public interfaces, for example,
+    // as far as native rules are concerned. Returning None on all unsupported invocations of
+    // native.[func_name]() is the safest "best effort" approach to implementing a fake for
+    // "native".
+    return new FakeStarlarkCallable(name);
+  }
+
+  @Override
+  public ImmutableCollection<String> getFieldNames() throws EvalException {
+    return ImmutableList.of();
+  }
+
+  @Nullable
+  @Override
+  public String getErrorMessageForUnknownField(String field) {
+    return "";
+  }
 }