commit 85e8d51c72c5dcb4d1f6a8f3186149339ca59fac
author brandjon <brandjon@google.com> Thu Dec 21 16:57:31 2017 -0800
committer Copybara-Service <copybara-piper@google.com> Thu Dec 21 16:59:14 2017 -0800
tree 674f045964f8479f8d150d030433b7c7d2e9596e
parent 7139420f25f1bfb3fdf3b50b1b260c339c94c20e

Remove testing flag --internal_do_not_export_builtins

Also add a @VisibleForTesting accessor to SkyframeExecutor.

RELNOTES: None
PiperOrigin-RevId: 179875655

src/main/java/com/google/devtools/build/lib/syntax/SkylarkSemantics.java

diff --git a/src/main/java/com/google/devtools/build/lib/syntax/SkylarkSemantics.java b/src/main/java/com/google/devtools/build/lib/syntax/SkylarkSemantics.java
index 9a6f915..c816cd6 100644
--- a/src/main/java/com/google/devtools/build/lib/syntax/SkylarkSemantics.java
+++ b/src/main/java/com/google/devtools/build/lib/syntax/SkylarkSemantics.java
@@ -58,7 +58,6 @@
   public abstract boolean incompatibleNewActionsApi();
   public abstract boolean incompatibleShowAllPrintMessages();
   public abstract boolean incompatibleStringIsNotIterable();
-  public abstract boolean internalDoNotExportBuiltins();
   public abstract boolean internalSkylarkFlagTestCanary();
 
   /** Returns a {@link Builder} initialized with the values of this instance. */
@@ -90,10 +89,9 @@
           .incompatibleLoadArgumentIsLabel(true)
           .incompatibleNewActionsApi(false)
           .incompatibleShowAllPrintMessages(true)
-          .incompatibleStringIsNotIterable(false)
-          .internalDoNotExportBuiltins(false)
-          .internalSkylarkFlagTestCanary(false)
-          .build();
+      .incompatibleStringIsNotIterable(false)
+      .internalSkylarkFlagTestCanary(false)
+      .build();
 
   /** Builder for {@link SkylarkSemantics}. All fields are mandatory. */
   @AutoValue.Builder
@@ -119,7 +117,6 @@
     public abstract Builder incompatibleNewActionsApi(boolean value);
     public abstract Builder incompatibleShowAllPrintMessages(boolean value);
     public abstract Builder incompatibleStringIsNotIterable(boolean value);
-    public abstract Builder internalDoNotExportBuiltins(boolean value);
     public abstract Builder internalSkylarkFlagTestCanary(boolean value);
 
     public abstract SkylarkSemantics build();