| commit | 0f0e607a33040aeb70a5bbee2ab2e770d2086789 | [log] [tgz] |
|---|---|---|
| author | Googler <shahan@google.com> | Sat May 27 06:45:41 2023 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Sat May 27 06:47:04 2023 -0700 |
| tree | f2ac4a2dc89b63794921146ecdd046cd79f3cf24 | |
| parent | e963ec52d0795cca581a40aa03bf2f17cd1b9b6e [diff] |
Embed ConfiguredTargetKey in ConfiguredTarget. This is for safety of ConfiguredTargetKey.fromConfiguredTarget, especially in the presence of ProxyConfiguredTargetKey. There's a number of places in the codebase that may assume that if a ConfiguredTargetValue is available, then it can be looked up using ConfiguredTargetKey.fromConfiguredTarget. Without this change, it is possible for a ProxyConfiguredTargetKey to fall out of the interner when the ConfiguredTarget does not have any Actions. The ensuing lookup would possibly result in null instead of the correct delegate value. * Since the key is present in the ConfiguredTarget already, KeyedConfiguredTargetValue no longer needs to exist and is deleted. * Minor improvement in fromConfiguredTarget soundness: not including executionPlatformLabel in fromConfiguredTarget makes it unsound for ConfiguredTargets that have one. PiperOrigin-RevId: 535850072 Change-Id: Idffcd0ed7809a3eaccb95ee666e9860cb856d21c
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
