commit | 869bd708149134de8e5681fd60e742742f01847e | [log] [tgz] |
---|---|---|
author | michajlo <michajlo@google.com> | Fri Jan 31 12:56:22 2020 -0800 |
committer | Copybara-Service <copybara-worker@google.com> | Fri Jan 31 12:57:21 2020 -0800 |
tree | 3af779b364810b7a26b8c2cd470fce747afe68bb | |
parent | 2d40d5c1f5c302f3f4e68876e3415b67f872b888 [diff] |
Delete the temporary install base if rename fails The extraction process creates a directory $install_base.tmp.XXXX, extracts the necessary install data into it, then moves it to $install_base. Typically the rename can fail if multiple instances race to create $install_base, but it can also fail for less predictable reasons. In either case, clean up the temp directory to avoid leaving unused data behind. Note that we can still leave a partial directory behind if something goes wrong with extracting data into the temp dir. This'll be a little harder to clean up, or alternatively it might also be something we want to leave in place for inspection after the fact. Windows implementation will come separately. I should be able to throw something together from the existing windows UnlinkPath and DeleteAllUnder (windows_test_util), but I lack a windows machine to able to move quickly, so I want to make sure this first pass sticks. RELNOTES: None PiperOrigin-RevId: 292599669
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
See CONTRIBUTING.md