commit 875c7a7b13b77ed65ceab1fe71d6c50e9647e36b
author Greg Estren <gregce@google.com> Thu Sep 24 19:57:54 2015 +0000
committer Han-Wen Nienhuys <hanwen@google.com> Fri Sep 25 14:40:19 2015 +0000
tree ef501a986d33bea6cdd8d5f20c05ad10efda9a61
parent 2833b42de91191632d64afe4a4d82c0aee26ad3d

Change Attribute.skipConstraintsCheck() (and similar methods)
to Attribute.skipPrereqValidatorCheck.

This is to disambiguate the concept of "constraints" and keep
the word consciously focused on Bazel's *new* constraint system.
The changed methods refer to checks done by PrerequisiteValidator,
which is basically an adhoc version of the "old" system (e.g.
checking visibility)

--
MOS_MIGRATED_REVID=103872412

src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java b/src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java
index 0a7f0be..9c4c2d1 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/BaseRuleClasses.java
@@ -176,7 +176,7 @@
           // The target itself and run_under both run on the same machine. We use the DATA config
           // here because the run_under acts like a data dependency (e.g. no LIPO optimization).
           .add(attr(":run_under", LABEL).cfg(DATA).value(RUN_UNDER)
-              .skipConstraintsCheck())
+              .skipPrereqValidatorCheck())
           .build();
     }
 

src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java b/src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java
index 4cdc269..10395cb 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java
@@ -1578,7 +1578,7 @@
       validateDirectPrerequisiteType(prerequisite, attribute);
       validateDirectPrerequisiteFileTypes(prerequisite, attribute);
       validateMandatoryProviders(prerequisite, attribute);
-      if (attribute.performConstraintsCheck()) {
+      if (attribute.performPrereqValidatorCheck()) {
         prerequisiteValidator.validate(this, prerequisite, attribute);
       }
     }