| commit | a45301346f565ebeb07b18dc405d8d9f96eab507 | [log] [tgz] |
|---|---|---|
| author | Googler <ajurkowski@google.com> | Tue Jan 03 10:20:04 2023 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Jan 03 10:21:27 2023 -0800 |
| tree | 04a2cde8bad940a1b102b8d06c19ecdeec5cbe90 | |
| parent | 58d89169dc9f7bcd2867f1bfe26b570e517efd87 [diff] |
Prevent change-pruning for `ActionExecutionValue` when the `discoveredModules` have changed. It is possible for a change to just the C++ features to add/remove actions for the corresponding configured target, which in turn affects the generating actions for the artifact (different action index). When than happens, the artifacts in an old `ActionExecutionValue::discoveredModules` may become stale. Today, in absence of any other change, such an `ActionExecutionValue` is subject to change-pruning leaving the value with stale `ActionLookupData`. That later will crash when a downstream action tries to use a discovered module with such artifact. Use `NestedSet::shallowEquals` which is potentially overly sensitive to avoid materializing the nested set just for the sake of comparison. This seems like a reasonable tradeoff since: 1. The output `.pcm` file is already quite sensitive to changes in transitive headers, making header edits in a dep affect the `ActionExecutionValue` for the module already. 2. Pure changes to C++ features are typically done via a change which affects the package, which affect the configured targets transitively (`RuleConfiguredTargetValue` has transitive packages and identity equality), this marks all actions being as `NEEDS_REBUILDING` anyway. PiperOrigin-RevId: 499254933 Change-Id: I88abaf62f767fee4c03fe1e108312cbff2b5f494
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
