commit 8bee7075bd797b50a8815cf1ae1f04b0f58b9fe0
author adonovan <adonovan@google.com> Wed Apr 29 11:59:53 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Apr 29 12:01:14 2020 -0700
tree 61427b2262eb8d55d5ffeb43067d3565a63df8de
parent 31dbddedbee84b90d851e1d6f0b5cb6bacaa5166

bazel syntax: remove depset special case in Starlark.type

Every place that wanted the "depset of T" message was either
already using Depset.cast, or doing its own thing (Py, Objc).
The fullDetails parameter has been deleted.

This breaks one more dependency from the interpreter to Depset.

Also:
- remove EvalUtils.getDataTypeName (use Starlark.type instead)
- rename EvalUtils.getDataTypeNameFromClass to Starlark.classType
  (The highlightNamespaces parameter was always true; deleted.)
PiperOrigin-RevId: 309067985

src/main/java/com/google/devtools/build/lib/packages/Attribute.java

diff --git a/src/main/java/com/google/devtools/build/lib/packages/Attribute.java b/src/main/java/com/google/devtools/build/lib/packages/Attribute.java
index a91d460..719dd09 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/Attribute.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/Attribute.java
@@ -1482,8 +1482,7 @@
       try {
         return type.cast((result == Starlark.NONE) ? type.getDefaultValue() : result);
       } catch (ClassCastException ex) {
-        throw Starlark.errorf(
-            "expected '%s', but got '%s'", type, EvalUtils.getDataTypeName(result, true));
+        throw Starlark.errorf("expected '%s', but got '%s'", type, Starlark.type(result));
       }
     }