commit 8d98d928b90209afb0c6cb38a785520805990fea
author janakr <janakr@google.com> Wed Oct 03 15:55:28 2018 -0700
committer Copybara-Service <copybara-piper@google.com> Wed Oct 03 15:56:56 2018 -0700
tree 45b2a7783420ea22526de1821a6fd0cd1f8c551b
parent 353dd7415959671a31e5a76ceac74aad21fd5b3e

Change hasChildChanged method name to childCausesReevaluation, to indicate that we may force the parent to re-evaluate even if the child's value hasn't changed.

PiperOrigin-RevId: 215644644

src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java

diff --git a/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java b/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java
index d498c41..fcc1d3b 100644
--- a/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java
+++ b/src/main/java/com/google/devtools/build/skyframe/InMemoryNodeEntry.java
@@ -463,7 +463,7 @@
     signaledDeps++;
     if (isDirty()) {
       dirtyBuildingState.signalDepInternal(
-          hasChildChanged(lastEvaluatedVersion, childVersion), isReady());
+          childCausesReevaluation(lastEvaluatedVersion, childVersion), isReady());
     }
     return isReady();
   }
@@ -654,8 +654,8 @@
     return isReady(getNumTemporaryDirectDeps());
   }
 
-  /** True if the child has changed since the last evaluated version. */
-  protected boolean hasChildChanged(Version lastEvaluatedVersion, Version childVersion) {
+  /** True if the child should cause re-evaluation of this node. */
+  protected boolean childCausesReevaluation(Version lastEvaluatedVersion, Version childVersion) {
     // childVersion > lastEvaluatedVersion
     return !childVersion.atMost(lastEvaluatedVersion);
   }