commit 8e9b28ffba3f9d5fb87192a7a660ef81d8d42d11
author cpeyser <cpeyser@google.com> Mon Jun 04 08:05:13 2018 -0700
committer Copybara-Service <copybara-piper@google.com> Mon Jun 04 08:11:10 2018 -0700
tree 3a6bf68419f4113704e18e23588ee4337b17bda1
parent 072154757970826b39715a67aaec15763d8be4a1

Failing targets are identified by comparing ConfiguredTarget.Key instead of ConfiguredTarget.  Since ConfiguredTarget does not implement equals(), reference equality has been used until now, and this is not valid for the case where the ConfiguredTarget has been deserialized.

PiperOrigin-RevId: 199133926

src/test/java/com/google/devtools/build/lib/skyframe/TimestampBuilderTestCase.java

diff --git a/src/test/java/com/google/devtools/build/lib/skyframe/TimestampBuilderTestCase.java b/src/test/java/com/google/devtools/build/lib/skyframe/TimestampBuilderTestCase.java
index 5bf742b..e17e673 100644
--- a/src/test/java/com/google/devtools/build/lib/skyframe/TimestampBuilderTestCase.java
+++ b/src/test/java/com/google/devtools/build/lib/skyframe/TimestampBuilderTestCase.java
@@ -264,7 +264,7 @@
           Set<ConfiguredTarget> targetsToSkip,
           Collection<AspectValue> aspects,
           Executor executor,
-          Set<ConfiguredTarget> builtTargets,
+          Set<ConfiguredTargetKey> builtTargets,
           Set<AspectKey> builtAspects,
           boolean explain,
           Range<Long> lastExecutionTimeRange,
@@ -407,7 +407,7 @@
 
     tsgm.setCommandStartTime();
     Set<Artifact> artifactsToBuild = Sets.newHashSet(artifacts);
-    Set<ConfiguredTarget> builtTargets = new HashSet<>();
+    Set<ConfiguredTargetKey> builtTargets = new HashSet<>();
     Set<AspectKey> builtAspects = new HashSet<>();
     try {
       builder.buildArtifacts(