commit 9012e6f2ddbca2af21f9ae892a9d2fb09841e304
author shahan <shahan@google.com> Mon Apr 02 13:26:14 2018 -0700
committer Copybara-Service <copybara-piper@google.com> Mon Apr 02 13:27:28 2018 -0700
tree 5137ee493a3760fe0b30b07b6cf007de3b96d68d
parent 41f7df715e83ddaf5a75b5738587c9d842ec75b4

Moves the decision to enable memoization from codecs to the top-level invocation.

Also, makes it benign to registerInitialValue when memoization is disabled.

PiperOrigin-RevId: 191338253

src/main/java/com/google/devtools/build/lib/syntax/Environment.java

diff --git a/src/main/java/com/google/devtools/build/lib/syntax/Environment.java b/src/main/java/com/google/devtools/build/lib/syntax/Environment.java
index 697c317..46253fa 100644
--- a/src/main/java/com/google/devtools/build/lib/syntax/Environment.java
+++ b/src/main/java/com/google/devtools/build/lib/syntax/Environment.java
@@ -25,7 +25,6 @@
 import com.google.devtools.build.lib.events.EventKind;
 import com.google.devtools.build.lib.events.Location;
 import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec;
-import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec.Memoization;
 import com.google.devtools.build.lib.skylarkinterface.SkylarkValue;
 import com.google.devtools.build.lib.syntax.Mutability.Freezable;
 import com.google.devtools.build.lib.syntax.Mutability.MutabilityException;
@@ -478,7 +477,7 @@
   @Immutable
   // TODO(janakr,brandjon): Do Extensions actually have to start their own memoization? Or can we
   // have a node higher up in the hierarchy inject the mutability?
-  @AutoCodec(memoization = Memoization.START_MEMOIZING)
+  @AutoCodec
   public static final class Extension {
 
     private final ImmutableMap<String, Object> bindings;