commit 904a8d63833301f54c7df85bccc56ff67156afc5
author ulfjack <ulfjack@google.com> Tue May 29 05:17:35 2018 -0700
committer Copybara-Service <copybara-piper@google.com> Tue May 29 05:18:35 2018 -0700
tree 3e272496bee7dee8f2d9c4690128e4f13cb323fe
parent ab2431e1ef62d91230fdef49b2556bbe60c9de56

Refactor root cause reporting in ConfiguredTargetFunction

We now track Causes instead of plain Labels, which will allow us to do better reporting in the future. Add basic tests.

PiperOrigin-RevId: 198380468

src/main/java/com/google/devtools/build/lib/analysis/AnalysisFailureEvent.java

diff --git a/src/main/java/com/google/devtools/build/lib/analysis/AnalysisFailureEvent.java b/src/main/java/com/google/devtools/build/lib/analysis/AnalysisFailureEvent.java
index b39d826..cdc26ef 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/AnalysisFailureEvent.java
+++ b/src/main/java/com/google/devtools/build/lib/analysis/AnalysisFailureEvent.java
@@ -23,8 +23,10 @@
 import com.google.devtools.build.lib.buildeventstream.GenericBuildEvent;
 import com.google.devtools.build.lib.buildeventstream.NullConfiguration;
 import com.google.devtools.build.lib.causes.Cause;
+import com.google.devtools.build.lib.cmdline.Label;
 import com.google.devtools.build.lib.skyframe.ConfiguredTargetKey;
 import java.util.Collection;
+import javax.annotation.Nullable;
 
 /**
  * This event is fired during the build, when it becomes known that the analysis of a target cannot
@@ -33,23 +35,37 @@
 public class AnalysisFailureEvent implements BuildEvent {
   private final ConfiguredTargetKey failedTarget;
   private final BuildEventId configuration;
-  private final Iterable<Cause> causes;
+  private final Iterable<Cause> rootCauses;
 
   public AnalysisFailureEvent(
-      ConfiguredTargetKey failedTarget, BuildEventId configuration, Iterable<Cause> causes) {
+      ConfiguredTargetKey failedTarget, BuildEventId configuration, Iterable<Cause> rootCauses) {
     this.failedTarget = failedTarget;
     if (configuration != null) {
       this.configuration = configuration;
     } else {
       this.configuration = NullConfiguration.INSTANCE.getEventId();
     }
-    this.causes = causes;
+    this.rootCauses = rootCauses;
   }
 
   public ConfiguredTargetKey getFailedTarget() {
     return failedTarget;
   }
 
+  /**
+   * Returns the label of a single root cause. Use {@link #getRootCauses} to report all root causes.
+   */
+  @Nullable public Label getLegacyFailureReason() {
+    if (!rootCauses.iterator().hasNext()) {
+      return null;
+    }
+    return rootCauses.iterator().next().getLabel();
+  }
+
+  public Iterable<Cause> getRootCauses() {
+    return rootCauses;
+  }
+
   @Override
   public BuildEventId getEventId() {
     return BuildEventId.targetCompleted(failedTarget.getLabel(), configuration);
@@ -57,7 +73,7 @@
 
   @Override
   public Collection<BuildEventId> getChildrenEvents() {
-    return ImmutableList.copyOf(Iterables.transform(causes, BuildEventId::fromCause));
+    return ImmutableList.copyOf(Iterables.transform(rootCauses, BuildEventId::fromCause));
   }
 
   @Override