commit 91ad93b9240d83165d16ec7d395bd16b7cdbb6d0
author Janak Ramakrishnan <janakr@google.com> Mon Aug 24 17:48:34 2015 +0000
committer Laszlo Csomor <laszlocsomor@google.com> Tue Aug 25 07:47:23 2015 +0000
tree 006bc2417e2ab09e71ee235db0e4c6b8cf6f2739
parent 0afd4539fc49d43f379a24e8b4ce6609cd2a503b

Make ValueWithMetadata#normal public, for use in alternate graph implementations.

--
MOS_MIGRATED_REVID=101379672

src/main/java/com/google/devtools/build/skyframe/ValueWithMetadata.java

diff --git a/src/main/java/com/google/devtools/build/skyframe/ValueWithMetadata.java b/src/main/java/com/google/devtools/build/skyframe/ValueWithMetadata.java
index 3795832..2c2110e 100644
--- a/src/main/java/com/google/devtools/build/skyframe/ValueWithMetadata.java
+++ b/src/main/java/com/google/devtools/build/skyframe/ValueWithMetadata.java
@@ -49,9 +49,11 @@
    * Builds a value entry value that has a value value, and possibly an error (constructed from its
    * children's errors).
    *
-   * <p>This is intended only for use in alternative {@code MemoizingEvaluator} implementations.
+   * <p>This is public only for use in alternative {@code MemoizingEvaluator} implementations.
    */
-  static SkyValue normal(@Nullable SkyValue value, @Nullable ErrorInfo errorInfo,
+  public static SkyValue normal(
+      @Nullable SkyValue value,
+      @Nullable ErrorInfo errorInfo,
       NestedSet<TaggedEvents> transitiveEvents) {
     Preconditions.checkState(value != null || errorInfo != null,
         "Value and error cannot both be null");
@@ -63,7 +65,6 @@
     return new ErrorInfoValue(errorInfo, value, transitiveEvents);
   }
 
-
   @Nullable SkyValue getValue() {
     return value;
   }
@@ -124,7 +125,7 @@
   }
 
   /** Implementation of {@link ValueWithMetadata} for the error case. */
-  public static final class ErrorInfoValue extends ValueWithMetadata {
+  private static final class ErrorInfoValue extends ValueWithMetadata {
 
     private final ErrorInfo errorInfo;
     private final NestedSet<TaggedEvents> transitiveEvents;