commit 9342003149a9ae348e9725cce8d62f653ebdea03
author janakr <janakr@google.com> Wed Oct 14 07:27:29 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Wed Oct 14 07:28:33 2020 -0700
tree f99f146fc38321e9b62b618367ae1eb19eddebc1
parent 334925f5f762127bdc9765e70603abc3cf8f89d4

Log when a failed query has no detailed exit code.

PiperOrigin-RevId: 337085951

src/main/java/com/google/devtools/build/lib/query2/common/AbstractBlazeQueryEnvironment.java

diff --git a/src/main/java/com/google/devtools/build/lib/query2/common/AbstractBlazeQueryEnvironment.java b/src/main/java/com/google/devtools/build/lib/query2/common/AbstractBlazeQueryEnvironment.java
index 6b9f0b2..05cb967 100644
--- a/src/main/java/com/google/devtools/build/lib/query2/common/AbstractBlazeQueryEnvironment.java
+++ b/src/main/java/com/google/devtools/build/lib/query2/common/AbstractBlazeQueryEnvironment.java
@@ -13,6 +13,8 @@
 // limitations under the License.
 package com.google.devtools.build.lib.query2.common;
 
+import static java.util.concurrent.TimeUnit.MINUTES;
+
 import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
@@ -250,6 +252,8 @@
       }
       throw new QueryException(expression, message, Query.Code.BUILD_FILE_ERROR);
     }
+    logger.atWarning().atMostEvery(1, MINUTES).log(
+        "Null detailed exit code for %s %s", message, expression);
     eventHandler.handle(createErrorEvent(expression, message, detailedExitCode));
   }
 
@@ -334,6 +338,9 @@
                   detailedExitCode.getFailureDetail().toBuilder()
                       .setMessage(eventMessage)
                       .build()));
+    } else {
+      logger.atWarning().atMostEvery(1, MINUTES).log(
+          "Null detailed exit code for %s %s", message, expr);
     }
     return event;
   }