commit 942e1c4a374a0ece069515d409e7acf9dac508d0
author Googler <noreply@google.com> Tue Nov 12 13:11:44 2019 -0800
committer Copybara-Service <copybara-worker@google.com> Tue Nov 12 13:12:45 2019 -0800
tree 7a79e541a3580ff5d39e8dd3f92e293debddcab7
parent 275cc6b067927c1bd5f5135c4d359f88d82b3a6b

bazel syntax: rename SkylarkList.MutableList to StarlarkList

This is the Java class that represents the Starlark 'list' data type.
We now have both SkylarkList and StarlarkList, which is confusing.
A follow-up change will globally rename SkylarkList to Sequence.

PiperOrigin-RevId: 280037310

src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java
index ed4f0cf..acb9d8f 100644
--- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java
+++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java
@@ -51,9 +51,9 @@
 import com.google.devtools.build.lib.syntax.EvalUtils;
 import com.google.devtools.build.lib.syntax.ParserInput;
 import com.google.devtools.build.lib.syntax.SkylarkDict;
-import com.google.devtools.build.lib.syntax.SkylarkList.MutableList;
 import com.google.devtools.build.lib.syntax.SkylarkNestedSet;
 import com.google.devtools.build.lib.syntax.StarlarkFile;
+import com.google.devtools.build.lib.syntax.StarlarkList;
 import com.google.devtools.build.lib.syntax.StarlarkThread;
 import com.google.devtools.build.lib.syntax.SyntaxError;
 import com.google.devtools.build.lib.syntax.Tuple;
@@ -1279,7 +1279,7 @@
     return StructProvider.STRUCT.create(
         ImmutableMap.<String, Object>of(
             "a",
-                MutableList.<Object>of(
+                StarlarkList.<Object>of(
                     thread,
                     StructProvider.STRUCT.create(
                         ImmutableMap.<String, Object>of(
@@ -1296,8 +1296,8 @@
     assertThat(EvalUtils.isImmutable(makeStruct("a", 1))).isTrue();
   }
 
-  private static MutableList<Object> makeList(StarlarkThread thread) {
-    return MutableList.<Object>of(thread, 1, 2, 3);
+  private static StarlarkList<Object> makeList(StarlarkThread thread) {
+    return StarlarkList.<Object>of(thread, 1, 2, 3);
   }
 
   @Test
@@ -1752,7 +1752,7 @@
     invalidatePackages();
     SkylarkRuleContext context = createRuleContext("//test:check");
     @SuppressWarnings("unchecked")
-    MutableList<Object> params = (MutableList<Object>) context.getAttr().getValue("params");
+    StarlarkList<Object> params = (StarlarkList<Object>) context.getAttr().getValue("params");
     assertThat(params.get(0)).isEqualTo("NoneType");
     assertThat(params.get(1)).isEqualTo("NoneType");
   }