commit 96be0c17f0f5576b6c16aa954590c0ecbadb2c8b
author Nathan Harmata <nharmata@google.com> Fri Sep 11 22:15:50 2015 +0000
committer Kristina Chodorow <kchodorow@google.com> Mon Sep 14 15:39:13 2015 +0000
tree 7734128fe10c6d62502757806923ea7dde629c23
parent 1d74b680ff096ba593b4135f0d40cca1c261bd79

Minor simple optimization in FileFunction: don't bother getting a FileStateValue for a path realpath 'parent/child' if 'parent' is known to not exist. This saves a stat for each ancestor path.

--
MOS_MIGRATED_REVID=102881929

src/main/java/com/google/devtools/build/lib/skyframe/FileFunction.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/FileFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/FileFunction.java
index 32cce31..bec8ed3 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/FileFunction.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/FileFunction.java
@@ -145,6 +145,9 @@
       RootedPath parentRealRootedPath = parentFileValue.realRootedPath();
       realRootedPath = RootedPath.toRootedPath(parentRealRootedPath.getRoot(),
           parentRealRootedPath.getRelativePath().getRelative(baseName));
+      if (!parentFileValue.exists()) {
+        return Pair.of(realRootedPath, FileStateValue.NONEXISTENT_FILE_STATE_NODE);
+      }
     }
     FileStateValue realFileStateValue =
         (FileStateValue) env.getValue(FileStateValue.key(realRootedPath));
@@ -155,7 +158,7 @@
         && parentFileValue != null && !parentFileValue.isDirectory()) {
       String type = realFileStateValue.getType().toString().toLowerCase();
       String message = type + " " + rootedPath.asPath() + " exists but its parent "
-          + "directory " + parentFileValue.realRootedPath().asPath() + " doesn't exist.";
+          + "path " + parentFileValue.realRootedPath().asPath() + " isn't an existing directory.";
       throw new FileFunctionException(new InconsistentFilesystemException(message),
           Transience.TRANSIENT);
     }

src/main/java/com/google/devtools/build/lib/skyframe/FileStateValue.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/FileStateValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/FileStateValue.java
index 3d06d7c..0be5c31 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/FileStateValue.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/FileStateValue.java
@@ -175,8 +175,8 @@
         String errorMessage = e.getMessage() != null
             ? "error '" + e.getMessage() + "'" : "an error";
         throw new InconsistentFilesystemException("'stat' said " + path + " is a file but then we "
-            + "later encountered " + errorMessage + " which indicates that " + path + " no longer "
-            + "exists. Did you delete it during the build?");
+            + "later encountered " + errorMessage + " which indicates that " + path + " is no "
+            + "longer a file. Did you delete it during the build?");
       }
     }