commit 97577290d27ad08e1bae72b4f6b67e608d4f9650
author bbaren <bbaren@google.com> Fri Jun 19 14:53:23 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Fri Jun 19 14:54:18 2020 -0700
tree ad076e05678f980e5f6db0a40a70d27e3a4e8dbd
parent 06b76c905d99bdc32ee196dc54cfe669bb6286ac

Don’t linkstamp `apple_binary` targets by default

A previous change* made `apple_binary` support the `stamp` attribute in
exactly the same way as `cc_binary` does, including defaulting it to
`AUTO` (i.e., controlled by the `--stamp`/`--nostamp` flag). This
creates a behavioral change, which may trigger unintended consequences.
For stability, change the `stamp` attribute to default to `NO`, thus
preserving the previous behavior while allowing individual targets to
opt in to stamping.

* https://github.com/bazelbuild/bazel/commit/3a28c96814e54d8e95f132a82cf501cf137d918e

RELNOTES: None.
PiperOrigin-RevId: 317385203

src/main/java/com/google/devtools/build/lib/rules/objc/AppleBinaryRule.java

diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/AppleBinaryRule.java b/src/main/java/com/google/devtools/build/lib/rules/objc/AppleBinaryRule.java
index c4c5aa0..0104dea 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/objc/AppleBinaryRule.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/objc/AppleBinaryRule.java
@@ -149,7 +149,7 @@
             by the <a href="../user-manual.html#flag--stamp">--[no]stamp</a> flag.</li>
         </ul>
         <!-- #END_BLAZE_RULE.ATTRIBUTE -->*/
-        .add(attr("stamp", TRISTATE).value(TriState.AUTO))
+        .add(attr("stamp", TRISTATE).value(TriState.NO))
         .add(
             attr("feature_flags", LABEL_KEYED_STRING_DICT)
                 .undocumented("the feature flag feature has not yet been launched")