commit 9885c2f31b731957a79033759024a48254a67dca
author michajlo <michajlo@google.com> Mon Mar 09 12:33:06 2020 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Mar 09 12:34:29 2020 -0700
tree 5346b85aafad1d8369538da4b8473373a01e5027
parent 78fdb7d62da15f7048cc3c170ca4fc03ff8f9bb2

Ensure no writes occur after StreamedTestOutput#close

There's a race on interrupt where the backing thread could write a little more
content before realizing it was supposed to exit. The new tests expose that race
with a moderate --runs_per_test.

RELNOTES: None
PiperOrigin-RevId: 299906419

src/main/java/com/google/devtools/build/lib/exec/StandaloneTestStrategy.java

diff --git a/src/main/java/com/google/devtools/build/lib/exec/StandaloneTestStrategy.java b/src/main/java/com/google/devtools/build/lib/exec/StandaloneTestStrategy.java
index 6d68f36..996df02 100644
--- a/src/main/java/com/google/devtools/build/lib/exec/StandaloneTestStrategy.java
+++ b/src/main/java/com/google/devtools/build/lib/exec/StandaloneTestStrategy.java
@@ -298,7 +298,7 @@
     Closeable streamed = null;
     if (executionOptions.testOutput.equals(TestOutputFormat.STREAMED)) {
       streamed =
-          new StreamedTestOutput(
+          createStreamedTestOutput(
               Reporter.outErrForReporter(actionExecutionContext.getEventHandler()), out);
     }
     long startTimeMillis = actionExecutionContext.getClock().currentTimeMillis();