commit 9b0b987e5df9a7e5d5c7cc09ed37d5ccaa8eb54e
author janakr <janakr@google.com> Tue Jun 19 09:45:57 2018 -0700
committer Copybara-Service <copybara-piper@google.com> Tue Jun 19 09:47:43 2018 -0700
tree 645c55142ebbc5eaea868551cac7bd4acca3ce70
parent d39de3a8849974c30609a2bc190fcbba6c237143

Clarify that ErrorInfoValue is a NotComparableSkyValue because we don't expect equality, not because there's no implementation.

PiperOrigin-RevId: 201191262

src/main/java/com/google/devtools/build/skyframe/ValueWithMetadata.java

diff --git a/src/main/java/com/google/devtools/build/skyframe/ValueWithMetadata.java b/src/main/java/com/google/devtools/build/skyframe/ValueWithMetadata.java
index a0c5108..8254f2e 100644
--- a/src/main/java/com/google/devtools/build/skyframe/ValueWithMetadata.java
+++ b/src/main/java/com/google/devtools/build/skyframe/ValueWithMetadata.java
@@ -179,10 +179,10 @@
   /**
    * Implementation of {@link ValueWithMetadata} for the error case.
    *
-   * ErorInfo does not override equals(), so it may as well be marked NotComparableSkyValue.
+   * <p>Mark NotComparableSkyValue because it's unlikely that re-evaluation gives the same error.
    */
   private static final class ErrorInfoValue extends ValueWithMetadata
-          implements NotComparableSkyValue {
+      implements NotComparableSkyValue {
 
     private final ErrorInfo errorInfo;
     private final NestedSet<TaggedEvents> transitiveEvents;