| commit | 0c0fea5bc338c46447b81dc45b0544c0f0d17518 | [log] [tgz] |
|---|---|---|
| author | Googler <leba@google.com> | Thu Sep 01 09:32:23 2022 -0700 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Sep 01 09:35:36 2022 -0700 |
| tree | de9cb8e2021e405e3624cf865ec6a162db9f763c | |
| parent | f14a31d5b175567702f39cdad1d60cbf411aafc1 [diff] |
[Skymeld] Move the setup for execution to after possible state resets before the analysis phase. The following scenario happened which caused a crash with Skymeld: 1. `blaze build -c opt //foo` => success 2. `blaze build //foo` => crash Between steps 1 & 2, the compilation mode changed, which forced bazel to clear the analysis cache. This clearing also involves clearing out the `packageRoots` in the `ArtifactFactory`. With Skymeld, we previously setup the `packageRoots` before this event, so the clearance would leave the `ArtifactFactory` with a null `packageRoots`. The NPE happened because of that. This CL fixes the issue by moving the preparation for execution later, so that it's guaranteed to be _after_ a potential analysis cache discarding. PiperOrigin-RevId: 471552769 Change-Id: I9206ff0bdc6cca0326b1a51e65668110c7faf977
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
