commit 9e10d3e9c90d0d0962f59a55fdd347ad2c20f8a2
author jmmv <jmmv@google.com> Wed Aug 01 10:25:07 2018 -0700
committer Copybara-Service <copybara-piper@google.com> Wed Aug 01 10:27:15 2018 -0700
tree 87cc48f4a53ff548404a1fe56c9bca2bab10980a
parent 1707cba6adb993e8b0f8520c563e7a66597c45a4

Use a parameterized dict and simplify an iteration in xcode-locator.

This raises the minimum version with which xcode-locator must be built
to Xcode 7.

Changes suggested by davg@ during the review of another change to the
xcode-locator.

RELNOTES: None.
PiperOrigin-RevId: 206949696

tools/osx/xcode_locator.m

diff --git a/tools/osx/xcode_locator.m b/tools/osx/xcode_locator.m
index 1565f6f..e247395 100644
--- a/tools/osx/xcode_locator.m
+++ b/tools/osx/xcode_locator.m
@@ -62,8 +62,9 @@
 //    precedence over installed versions.)
 //
 // 2. Not older (at least as high version number).
-static void AddEntryToDictionary(XcodeVersionEntry *entry,
-                                 NSMutableDictionary *dict) {
+static void AddEntryToDictionary(
+  XcodeVersionEntry *entry,
+  NSMutableDictionary<NSString *, XcodeVersionEntry *> *dict) {
   BOOL inApplications =
       [entry.url.path rangeOfString:@"/Applications/"].location != NSNotFound;
   NSString *entryVersion = entry.version;
@@ -113,10 +114,12 @@
 //
 // If there is a problem locating the Xcodes, prints one or more error messages
 // and returns nil.
-static NSMutableDictionary *FindXcodes() __attribute((ns_returns_retained)) {
+static NSMutableDictionary<NSString *, XcodeVersionEntry *> *FindXcodes()
+  __attribute((ns_returns_retained)) {
   CFStringRef bundleID = CFSTR("com.apple.dt.Xcode");
 
-  NSMutableDictionary *dict = [[NSMutableDictionary alloc] init];
+  NSMutableDictionary<NSString *, XcodeVersionEntry *> *dict =
+      [[NSMutableDictionary alloc] init];
   CFErrorRef cfError;
   NSArray *array = CFBridgingRelease(LSCopyApplicationURLsForBundleIdentifier(
       bundleID, &cfError));
@@ -171,17 +174,22 @@
 
 // Prints out the located Xcodes as a set of lines where each line contains the
 // list of versions for a given Xcode and its location on disk.
-static void DumpAsVersionsOnly(FILE *output, NSMutableDictionary *dict) {
-  NSSet *distinctValues = [[NSSet alloc] initWithArray:[dict allValues]];
-  NSMutableDictionary *aliasDict = [[NSMutableDictionary alloc] init];
-  for (XcodeVersionEntry *value in distinctValues) {
-    NSString *versionString = value.version;
+static void DumpAsVersionsOnly(
+  FILE *output,
+  NSMutableDictionary<NSString *, XcodeVersionEntry *> *dict) {
+  NSSet<XcodeVersionEntry *> *distinctValues =
+      [[NSSet alloc] initWithArray:dict.allValues];
+  NSMutableDictionary<NSString *, NSMutableSet <NSString *> *> *aliasDict =
+      [[NSMutableDictionary alloc] init];
+  [dict enumerateKeysAndObjectsUsingBlock:^(NSString *aliasVersion,
+                                            XcodeVersionEntry *entry,
+                                            BOOL *stop) {
+    NSString *versionString = entry.version;
     if (aliasDict[versionString] == nil) {
       aliasDict[versionString] = [[NSMutableSet alloc] init];
     }
-    [aliasDict[versionString]
-        addObjectsFromArray:[dict allKeysForObject:value]];
-  }
+    [aliasDict[versionString] addObject:aliasVersion];
+  }];
   for (NSString *version in aliasDict) {
     XcodeVersionEntry *entry = dict[version];
     fprintf(output, "%s:%s:%s\n",
@@ -193,7 +201,9 @@
 }
 
 // Prints out the located Xcodes in JSON format.
-static void DumpAsJson(FILE *output, NSMutableDictionary *dict) {
+static void DumpAsJson(
+  FILE *output,
+  NSMutableDictionary<NSString *, XcodeVersionEntry *> *dict) {
   fprintf(output, "{\n");
   for (NSString *version in dict) {
     XcodeVersionEntry *entry = dict[version];
@@ -250,7 +260,7 @@
       return 1;
     }
 
-    NSMutableDictionary *dict = FindXcodes();
+    NSMutableDictionary<NSString *, XcodeVersionEntry *> *dict = FindXcodes();
     if (dict == nil) {
       return 1;
     }