commit 9e91f20bb31e44b4be836996ac9d91af61e1e822
author tomlu <tomlu@google.com> Mon Jun 18 16:16:36 2018 -0700
committer Copybara-Service <copybara-piper@google.com> Mon Jun 18 16:18:08 2018 -0700
tree 7e7c116290099ef5a8e16e67a9d4f5a0c908fbf9
parent d4406d644efcf86327834a56b01cc212389e52e7

Remove support for --discard_actions_after_execution.

The memory savings from this flag are not worth the complexity, and it interferes with action restarting.

RELNOTES: Remove support for --discard_actions_after_execution.
PiperOrigin-RevId: 201077905

src/main/java/com/google/devtools/build/lib/skyframe/BuildInfoCollectionValue.java

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/BuildInfoCollectionValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/BuildInfoCollectionValue.java
index fcaa762..6b6c7d1 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/BuildInfoCollectionValue.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/BuildInfoCollectionValue.java
@@ -14,6 +14,7 @@
 package com.google.devtools.build.lib.skyframe;
 
 import com.google.common.base.Preconditions;
+import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.Interner;
 import com.google.devtools.build.lib.actions.ActionAnalysisMetadata;
@@ -27,7 +28,6 @@
 import com.google.devtools.build.lib.concurrent.BlazeInterners;
 import com.google.devtools.build.lib.skyframe.serialization.autocodec.AutoCodec;
 import com.google.devtools.build.skyframe.SkyFunctionName;
-import java.util.ArrayList;
 import java.util.Objects;
 
 /**
@@ -38,22 +38,18 @@
 public class BuildInfoCollectionValue extends BasicActionLookupValue {
   private final BuildInfoCollection collection;
 
-  BuildInfoCollectionValue(
-      BuildInfoCollection collection,
-      GeneratingActions generatingActions,
-      boolean removeActionsAfterEvaluation) {
-    super(generatingActions, removeActionsAfterEvaluation);
+  BuildInfoCollectionValue(BuildInfoCollection collection, GeneratingActions generatingActions) {
+    super(generatingActions);
     this.collection = collection;
   }
 
   @AutoCodec.Instantiator
   @AutoCodec.VisibleForSerialization
   BuildInfoCollectionValue(
-      ArrayList<ActionAnalysisMetadata> actions,
+      ImmutableList<ActionAnalysisMetadata> actions,
       ImmutableMap<Artifact, Integer> generatingActionIndex,
-      BuildInfoCollection collection,
-      boolean removeActionsAfterEvaluation) {
-    super(actions, generatingActionIndex, removeActionsAfterEvaluation);
+      BuildInfoCollection collection) {
+    super(actions, generatingActionIndex);
     this.collection = collection;
   }