commit 9eca6d565b30e700a4e6babed075a7eec41917dd
author Googler <noreply@google.com> Wed Nov 13 06:26:47 2019 -0800
committer Copybara-Service <copybara-worker@google.com> Wed Nov 13 06:28:15 2019 -0800
tree e3e859881daf5b9d32139dc9db6a53100a791ed6
parent 6bebe387446d0d5eb260e87ae74c7f11ba67e27b

bazel syntax: delete BaseFunction.name field

Leave getName method abstract.
Some subclasses want a field, others need a method.

BaseFunction is one step closer to becoming an interface.

Also:
- eliminate ProviderFromFunction, which was not an abstraction but merely
  code-reuse hack.
- inline FakeStarlarkCallable class into sole point of use.
PiperOrigin-RevId: 280185359

src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java

diff --git a/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java b/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java
index ff07322..231b373 100644
--- a/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java
+++ b/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java
@@ -2088,7 +2088,12 @@
               "values_only_field",
               "fromValues",
               "values_only_method",
-              new BuiltinFunction("values_only_method", FunctionSignature.of()) {
+              new BuiltinFunction(FunctionSignature.of()) {
+                @Override
+                public String getName() {
+                  return "values_only_method";
+                }
+
                 public String invoke() {
                   return "fromValues";
                 }
@@ -2096,7 +2101,12 @@
               "collision_field",
               "fromValues",
               "collision_method",
-              new BuiltinFunction("collision_method", FunctionSignature.of()) {
+              new BuiltinFunction(FunctionSignature.of()) {
+                @Override
+                public String getName() {
+                  return "collision_method";
+                }
+
                 public String invoke() {
                   return "fromValues";
                 }