Fix grpc connection pool race condition (https://github.com/bazelbuild/bazel/pull/29684)

Previously calling `withChannelConnection` claimed and closed a
connection from the `dynamicConnectionPool` instantly, even if there
were still remote exec requests in flight. This mean the connection went
back into the pool and would be reused by bazel even if it already had
the maximum number of MAX_CONCURRENT_STREAMS in flight. The end result
is that when you set `--jobs=500` your number of concurrent remote exec
actions could still be gated by `MAX_CONCURRENT_STREAMS` over a single
connection.

This seems to race based on how quickly bazel ends up creating another
connection before it closes the first one.

Related: https://github.com/bazelbuild/bazel/issues/11801

Closes #29684.

PiperOrigin-RevId: 925216366
Change-Id: Ic7744c6a92bbeb1df2ea5faeb83869403ef5dd96
2 files changed
tree: 6510b1fc53ef0fd0e9a7bda4d60c88979e0023a3
  1. .bazelci/
  2. .devcontainer/
  3. .gemini/
  4. .github/
  5. docs/
  6. examples/
  7. scripts/
  8. site/
  9. src/
  10. third_party/
  11. tools/
  12. .bazelrc
  13. .bazelversion
  14. .gitattributes
  15. .gitignore
  16. AGENTS.md
  17. AUTHORS
  18. bazel_downloader.cfg
  19. BUILD
  20. CHANGELOG.md
  21. CODE_OF_CONDUCT.md
  22. CODEOWNERS
  23. combine_distfiles.py
  24. combine_distfiles_to_tar.sh
  25. compile.sh
  26. CONTRIBUTING.md
  27. CONTRIBUTORS
  28. distdir.bzl
  29. extensions.bzl
  30. LICENSE
  31. maven_install.json
  32. MODULE.bazel
  33. MODULE.bazel.lock
  34. oneversion_allowlist.csv
  35. oneversion_allowlist_for_tests.csv
  36. pyproject.toml
  37. README.md
  38. repositories.bzl
  39. requirements.txt
  40. SECURITY.md
README.md

Bazel

{Fast, Correct} - Choose two

Build and test software of any size, quickly and reliably.

  • Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.

  • One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.

  • Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.

  • Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.

Getting Started

Documentation

Reporting a Vulnerability

To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.

Contributing to Bazel

See CONTRIBUTING.md

Build status