Abort query evaluation early in no-keep-going mode if preloading the transitive closure of a set of target fails *and* the transitive closure needed was unbounded.

This prevents pathological behavior of a no-keep-going query encountering an error,  printing it, aborting Skyframe preloading evaluation, and then sequentially loading packages in LabelVisitor because they weren't loaded in the preloading phase.

That pathological behavior is still possible with a depth bound, but this gets rid of a class of such issues.

To facilitate this, moved QueryTransitivePackagePreloader into the query2 tree, and made the maxDepth an OptionalInt. This might also theoretically allow us to process graphs of depth > Integer.MAX_VALUE although I'm pretty sure we'd blow up for a dozen other reasons first.

PiperOrigin-RevId: 429454209
37 files changed
tree: 992acabca50944eb89fded73ee59f5d1dfbf327e
  1. .bazelci/
  2. .github/
  3. examples/
  4. scripts/
  5. site/
  6. src/
  7. third_party/
  8. tools/
  9. .bazelrc
  10. .gitattributes
  11. .gitignore
  12. AUTHORS
  13. BUILD
  14. CHANGELOG.md
  15. CODE_OF_CONDUCT.md
  16. CODEBASE.md
  17. CODEOWNERS
  18. combine_distfiles.py
  19. combine_distfiles_to_tar.sh
  20. compile.sh
  21. CONTRIBUTING.md
  22. CONTRIBUTORS
  23. distdir.bzl
  24. distdir_deps.bzl
  25. ISSUE_TEMPLATE.md
  26. LICENSE
  27. MODULE.bazel
  28. README.md
  29. SECURITY.md
  30. WORKSPACE
  31. WORKSPACE.bzlmod
README.md

Bazel

{Fast, Correct} - Choose two

Build and test software of any size, quickly and reliably.

  • Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.

  • One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.

  • Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.

  • Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.

Getting Started

Documentation

Reporting a Vulnerability

To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.

Contributing to Bazel

See CONTRIBUTING.md

Build status