Fix incorrect RunfilesSupplier in TestRunnerAction
Create a valid RunfilesSupplier in the TestRunnerAction and remove the workarounds
in the test strategy implementations.
Additionally, remove harmful BaseSpawn construct that would hide the fact that it
discards any RunfilesSupplier.
PiperOrigin-RevId: 266114115
diff --git a/src/main/java/com/google/devtools/build/lib/exec/StandaloneTestStrategy.java b/src/main/java/com/google/devtools/build/lib/exec/StandaloneTestStrategy.java
index 01fbc1c..bbe2c3d 100644
--- a/src/main/java/com/google/devtools/build/lib/exec/StandaloneTestStrategy.java
+++ b/src/main/java/com/google/devtools/build/lib/exec/StandaloneTestStrategy.java
@@ -32,7 +32,6 @@
import com.google.devtools.build.lib.actions.SpawnActionContext;
import com.google.devtools.build.lib.actions.SpawnContinuation;
import com.google.devtools.build.lib.actions.SpawnResult;
-import com.google.devtools.build.lib.analysis.RunfilesSupplierImpl;
import com.google.devtools.build.lib.analysis.actions.SpawnAction;
import com.google.devtools.build.lib.analysis.test.TestActionContext;
import com.google.devtools.build.lib.analysis.test.TestResult;
@@ -133,8 +132,7 @@
getArgs(action),
ImmutableMap.copyOf(env),
ImmutableMap.copyOf(executionInfo),
- new RunfilesSupplierImpl(
- runfilesDir.relativeTo(execRoot), action.getExecutionSettings().getRunfiles()),
+ action.getRunfilesSupplier(),
ImmutableMap.of(),
/*inputs=*/ ImmutableList.copyOf(action.getInputs()),
/*tools=*/ ImmutableList.<Artifact>of(),