| commit | a3f0bfa99ccc722e90a69d34e7efb385e7ed749d | [log] [tgz] |
|---|---|---|
| author | Googler <ilist@google.com> | Thu Feb 23 12:21:54 2023 -0800 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Feb 23 12:23:10 2023 -0800 |
| tree | bae77a7cc9ffc1707939f3a36703e71427537048 | |
| parent | 32e4f23ec67909e92313be4d3334b62ccb490d55 [diff] |
Starlarkify ProtoInfo
The Starlark version needs to follow fields as they were exposed on ProtoInfoApi.
The change is slightly confusing, because native fields are sometimes named differently from Starlark ones. Here's the mapping:
Type | Native field | Starlark field
:------------------ | :--------------------- | :---
Artifact | directDescriptorSet | direct_descriptor_set
List<ProtoSource> | directSources | _direct_proto_sources (private)
List<Artifact> | directProtoSources | direct_sources = extractProtoSources(directSources)
PathFragment | directProtoSourceRoot | proto_source_root = directProtoSourceRoot.getSafePathString();
NestedSet<ProtoSource> | transitiveSources | _transitive_proto_sources (private)
NestedSet<Artifact> | transitiveProtoSources | transitive_imports, transitive_sources
NestedSet<String> | transitiveProtoSourceRoots | transitive_proto_path
NestedSet<Artifact> | strictImportableProto-SourcesForDependents | check_deps_sources
NestedSet<Artifact> | transitiveDescriptorSets | transitive_descriptor_sets
NestedSet<ProtoSource> | exportedSources | _exported_sources (private)
The fields `transitive_imports` and `transitive_sources` are duplicated in Starlark.
Native `directProtoSourceRoot` was interned using `ProtoCommon.memoryEfficientProtoSourceRoot`. There's no optimisation on `proto_source_root`, for now it doesn't seem necessary and I have ideas how to optimise `ProtoInfo` further without it.
The change introduces a slight regression in retained heap on benchmarked builds <0.1%. It's caused because of extra containers. That is in Starlark each instance needs two references and an Object array, whereas natively there's no need for references or arrays: `StarlarkInfo { ProtoInfo.class, Object[]{ f1, f2 } } > ProtoInfo { f1,f2 }`.
PiperOrigin-RevId: 511854620
Change-Id: I239aef427898e30e4f264f002e79b69eeaaa34db
{Fast, Correct} - Choose two
Build and test software of any size, quickly and reliably.
Speed up your builds and tests: Bazel rebuilds only what is necessary. With advanced local and distributed caching, optimized dependency analysis and parallel execution, you get fast and incremental builds.
One tool, multiple languages: Build and test Java, C++, Android, iOS, Go, and a wide variety of other language platforms. Bazel runs on Windows, macOS, and Linux.
Scalable: Bazel helps you scale your organization, codebase, and continuous integration solution. It handles codebases of any size, in multiple repositories or a huge monorepo.
Extensible to your needs: Easily add support for new languages and platforms with Bazel's familiar extension language. Share and re-use language rules written by the growing Bazel community.
Follow our tutorials:
To report a security issue, please email security@bazel.build with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue. Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory. This project follows a 90 day disclosure timeline.
See CONTRIBUTING.md
