commit a55714cab4d75ef944e815baf3f1ae5ec9418812
author Klaus Aehlig <aehlig@google.com> Tue Oct 23 02:16:02 2018 -0700
committer Copybara-Service <copybara-piper@google.com> Tue Oct 23 02:17:11 2018 -0700
tree b65868fdb8f09ba62e5ada9b2411ef12f26a1024
parent 2fda17d46088f2bb07b049fa35759002ea1dd5db

Set default of --incompatible_remove_native_{http_archive,git_repository} to true

...and switch tests to test the skylark implementation rather than the (deprecated,
by default disabled) native implementation.

(Rollforward with remaining calls to the native funcitons in the WORKSPACE
 adapted as well, tus fixing bazel_determinism_test.)

Change-Id: I3b604a27615f36463e62112dd02319fcf24f90f0
PiperOrigin-RevId: 218309750

src/main/java/com/google/devtools/build/lib/syntax/SkylarkSemantics.java

diff --git a/src/main/java/com/google/devtools/build/lib/syntax/SkylarkSemantics.java b/src/main/java/com/google/devtools/build/lib/syntax/SkylarkSemantics.java
index df6e9f9..cb3886d 100644
--- a/src/main/java/com/google/devtools/build/lib/syntax/SkylarkSemantics.java
+++ b/src/main/java/com/google/devtools/build/lib/syntax/SkylarkSemantics.java
@@ -219,8 +219,8 @@
           .incompatibleNoTransitiveLoads(false)
           .incompatiblePackageNameIsAFunction(false)
           .incompatibleRangeType(false)
-          .incompatibleRemoveNativeGitRepository(false)
-          .incompatibleRemoveNativeHttpArchive(false)
+          .incompatibleRemoveNativeGitRepository(true)
+          .incompatibleRemoveNativeHttpArchive(true)
           .incompatibleStaticNameResolution(false)
           .incompatibleStringIsNotIterable(false)
           .internalSkylarkFlagTestCanary(false)