commit a66a56b108c04f05efcb9b965361d692435acc59
author Liam Miller-Cushon <cushon@google.com> Fri Jul 15 21:03:11 2016 +0000
committer Yun Peng <pcloudy@google.com> Mon Jul 18 10:44:10 2016 +0000
tree 30c0c45b163f1b2c8f7849713ef53e91a8e49e15
parent a2770334ea3f3111026eb3e1368586921468710c

Drop Error Prone-specific javacopts

--
MOS_MIGRATED_REVID=127576227

src/java_tools/buildjar/java/com/google/devtools/build/java/bazel/BazelJavaCompiler.java

diff --git a/src/java_tools/buildjar/java/com/google/devtools/build/java/bazel/BazelJavaCompiler.java b/src/java_tools/buildjar/java/com/google/devtools/build/java/bazel/BazelJavaCompiler.java
index d0a1c71..6a4156a 100644
--- a/src/java_tools/buildjar/java/com/google/devtools/build/java/bazel/BazelJavaCompiler.java
+++ b/src/java_tools/buildjar/java/com/google/devtools/build/java/bazel/BazelJavaCompiler.java
@@ -28,7 +28,6 @@
 import java.util.List;
 import java.util.Locale;
 import java.util.Set;
-
 import javax.lang.model.SourceVersion;
 import javax.tools.DiagnosticListener;
 import javax.tools.JavaCompiler;
@@ -55,8 +54,15 @@
 
   private static final String[] DEFAULT_JAVACOPTS;
   static {
-    List<String> defaultJavacopts = new ArrayList<>(JavaBuilderConfig.defaultJavacOpts());
-    
+    List<String> defaultJavacopts = new ArrayList<>();
+    for (String javacopt : JavaBuilderConfig.defaultJavacOpts()) {
+      if (javacopt.startsWith("-Xep")) {
+        // ignore Error Prone-specific flags accepted by JavaBuilder
+        continue;
+      }
+      defaultJavacopts.add(javacopt);
+    }
+
     // The bootclasspath must be specified both via an invocation option and
     // via fileManager.setLocation(PLATFORM_CLASS_PATH), to work around what
     // appears to be a bug in jdk[6,8] javac.
@@ -145,7 +151,7 @@
    */
   public static JavaCompiler newInstance() {
     try {
-      return newInstance(JAVA_COMPILER_CLASS.newInstance());
+      return newInstance(JAVA_COMPILER_CLASS.getConstructor().newInstance());
     } catch (Exception e) {
       throw new RuntimeException("Cannot get java compiler", e);
     }
@@ -171,7 +177,7 @@
    */
   public static JavaCompiler newInstance(ClassLoader cl) {
     try {
-      return newInstance(getJavaCompilerClass(cl).newInstance());
+      return newInstance(getJavaCompilerClass(cl).getConstructor().newInstance());
     } catch (Exception e) {
       throw new RuntimeException("Cannot get java compiler", e);
     }